Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx docs build issue #74

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

JMorado
Copy link
Contributor

@JMorado JMorado commented Apr 9, 2024

Sphinx is having trouble with the two links for MACE in the README.md file added in PR #72, which are preventing the docs from building properly. I've tested this fix on my fork, and it seems to resolve the issue.

@peastman
Copy link
Member

peastman commented Apr 9, 2024

As far as I can tell, all you changed was to move the word "implementation" into the link description? What was the problem?

@JMorado
Copy link
Contributor Author

JMorado commented Apr 9, 2024

The problem was that there were two links associated with the MACE keyword: one pointing to https://arxiv.org/abs/2206.07697 and another to the repository https://github.com/ACEsuit/mace. It appears that Sphinx does not handle this well.

@peastman
Copy link
Member

peastman commented Apr 9, 2024

Ok. Thanks!

@peastman peastman merged commit df00239 into openmm:main Apr 9, 2024
@JMorado JMorado deleted the fix-docs-pr-72 branch April 9, 2024 17:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants