Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS is modified by make install/make run #3608

Closed
camilstaps opened this issue Jun 16, 2023 · 0 comments · Fixed by #3689
Closed

CSS is modified by make install/make run #3608

camilstaps opened this issue Jun 16, 2023 · 0 comments · Fixed by #3689
Assignees
@joemull
Labels
bug Something's not working

Comments

@camilstaps
Copy link

camilstaps commented Jun 16, 2023 •
edited
Loading

Describe the bug
When installing and running a new instance using make install and make run, two CSS files are modified:

  • src/static/OLH/css/app.css
  • src/static/clean/css/clean.css

I would expect the changeset to be empty; the files could be ignored if generated, or a new version could be committed.

Janeway version
2fb70af

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repository, and apply Fix "make install" error on pristine clone #3607 to be able to install (I cannot see a way in which that change would cause this issue)
  2. Run make install and make run
  3. Run git status

Expected behavior
The changeset is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joemull joemull

Labels
bug Something's not working
Projects
No open projects
v1.5.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CSS output files to .gitignore openlibhums/janeway
2 participants
@camilstaps @joemull