-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OIDExternalUserAgentIOSCustomBrowser on iOS 10+ #871
base: master
Are you sure you want to change the base?
Conversation
@yalkhder Do you know why the I tried the check's steps on my machine, that passed: `swift test` output...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loic-sharma thanks for this fix for OIDExternalUserAgentIOSCustomBrowser, the last check spm-build-test in github-actions is failing. Could you please look into it?
Please merge it as |
@ankushkushwaha Please see my message above. The test passes locally on my machine. I can't see the CI's output, so I can't tell what's going wrong there. Would you be able to help get additional information from the CI failure? |
UIApplication openURL:
is deprecated and has no effect.On iOS 10.0+,
UIApplication openURL:options:completionHandler:
should be used instead.I am contributing on behalf of Google, which has a CLA with the OpenID Foundation.
Relevant issue: #703