Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump iOS minimum version in podspec to support Xcode 14.3 #761

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Bump iOS minimum version in podspec to support Xcode 14.3 #761

merged 3 commits into from
Apr 7, 2023

Conversation

mdmathias
Copy link
Collaborator

Fixes #759

@mdmathias mdmathias mentioned this pull request Apr 6, 2023
Closed
paulb777
paulb777 reviewed Apr 6, 2023
View reviewed changes
AppAuth.podspec Outdated Show resolved Hide resolved
@mdmathias mdmathias marked this pull request as ready for review April 6, 2023 22:33
paulb777
paulb777 approved these changes Apr 6, 2023
View reviewed changes
Copy link

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Remember to also bump the podspec version to 1.6.1 or 1.7.0 before publishing to CocoaPods trunk. My recommendation without full context would be 1.6.1 to make it as seamless as possible for clients to get the update.

@mdmathias
Copy link
Collaborator Author

Thanks @paulb777 for the reminder. The last time we bumped a minimum OS version, we did a minor release.

de08e78

I'm inclined to stick with that precedent. Thoughts?

@paulb777
Copy link

paulb777 commented Apr 7, 2023 •
edited
Loading

If the version bump affected Xcodes that are still currently be used, I would agree that it needs to be a minor version update. Since this is changing from a long ago version to a still unsupported version, I think a patch version update is better so that clients that lock to a minor version also get the fix without a respin of their podspec or Podfile.

jmagman
jmagman approved these changes Apr 7, 2023
View reviewed changes
Copy link

@jmagman jmagman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the version bump is handled, thanks!

@mdmathias mdmathias requested a review from ch40w31 April 7, 2023 19:23
@jmagman jmagman mentioned this pull request Apr 7, 2023
Closed
@mdmathias mdmathias merged commit ecc52c5 into master Apr 7, 2023
@mdmathias mdmathias deleted the mdmathias/fix-for-xcode-143 branch April 7, 2023 20:35
@jordanhbuiltbyhq jordanhbuiltbyhq mentioned this pull request Apr 19, 2023
Open
@psharanda psharanda mentioned this pull request Apr 23, 2023
Merged
@jordanhbuiltbyhq jordanhbuiltbyhq mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@jmagman jmagman jmagman approved these changes

@ch40w31 ch40w31 ch40w31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCode 14.3 Beta cant archieve app because of AppAuth.framework pod
4 participants
@mdmathias @paulb777 @jmagman @ch40w31