parameters: Allow 'latest' as a valid release value #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! It looks good to me but since we're both working at Oslandia, I let a member from another organization merging this. |
ptitjano
force-pushed
the
allow-latest-version
branch
from
6b4dc97
to
6235c68
Compare
Gustry
approved these changes
Dec 22, 2023
ptitjano
force-pushed
the
allow-latest-version
branch
from
0283e91
to
4633882
Compare
This is a follow-up of 582278d which introduced support to check for correct release version patterns. This only allows semvar related values. However, the `package` command uses the `latest` version by default. This means that the command `qgis-plugin-ci package` now fails because `latest` pattern is not allowed. This issue is fixed by adding `^latest$` to the allowed patterns in version check.
ptitjano
force-pushed
the
allow-latest-version
branch
from
4633882
to
d8361c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of 582278d which introduced support to check for correct release version patterns. This only allows semvar related values.
However, the
packagecommand uses thelatestversion by default. This means that the commandqgis-plugin-ci packagenow fails becauselatestpattern is not allowed.This issue is fixed by adding
^latest$to the allowed patterns in version check.