Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JSON Schema definition to format-specs/ #93

Merged

Conversation

kylebarron
Copy link
Collaborator

For #64. This is intended to make the JSON Schema definition a more "focal" part of the specification.

The symlink here gets resolved when building the Python package, so a wheel or sdist will still include a physical copy of the schema:

> python setup.py sdist > /dev/null && tar -tf dist/geoparquet_validator-0.0.1.tar.gz | grep schema.json
geoparquet_validator-0.0.1/geoparquet_validator/schema.json

@cholmes cholmes added this to the 0.4 milestone May 10, 2022
@cholmes
Copy link
Member

cholmes commented May 10, 2022

Note that once we do this then any PR that updates the text likely should also update the JSON file. I think this is a win, but we probably should note that somewhere, and be sure to catch it in reviews. Thinking about like #94 - wondering if it needs a JSON schema update?

@kylebarron
Copy link
Collaborator Author

Thinking about like #94 - wondering if it needs a JSON schema update?

Yes the json schema definition would need to be updated to allow null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants