-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on winding order #59
Conversation
Related to #46 |
1 similar comment
From this #46 (comment), this covers the |
I think @felixpalmer proposes to force this winding order for both cases |
Yes, but I think we also need to specify the orientation rule. It probably makes sense to follow MS SQL, and Google BigQuery and 'interpret the side to the left of the line as the content of the ring'. |
I commented on the issue for the more general discussion (#46). But specific comment on the text in this PR: can we avoid using the term "right hand rule"? I know the GeoJSON spec uses this, but that term is very confusing, as other sources use "left hand" to specify the same .. (eg the cited bigquery and MS SQL sources) |
Thanks @jorisvandenbossche and @cholmes. @felixpalmer I think makes sense to specify that to be more explicit. |
Late to the party, but I agree that this is good to specify. I think mentioning the "right-hand rule" is ok (as some people may know it), but that it also makes sense to add some more detail (something like "the interior of the polygon is to the left of the boundary as you traverse vertices in order"). Inevitably, consumers of the data will do orientation checks before rendering, topology operations, etc. (as the data gets passed through structures that don't keep track of or require a specific orientation), but I still think it improves things to have the format specify how polygon rings are to be interpreted. |
Co-authored-by: Tim Schaub <tschaub@users.noreply.github.com>
@tschaub this is one of the latest PRs of v02.0. I've added your commit suggestion. Could you add your stamp here? |
I agree on the clarification here, it makes it more accessible to wider reader base |
No description provided.