Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "epoch" field to optionally specify the coordinate epoch for a dynamic CRS #49

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

jorisvandenbossche
Copy link
Collaborator

See first bullet point from #35 (and the following discussion).

This borrows a bit of text from https://gdal.org/user/coordinate_epoch.html (cc @rouault)

Copy link
Member

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though does 4326 need an epoch? If so we should add what people should put for the epoch if they are using our crs recommendation for interoperability.

@jorisvandenbossche
Copy link
Collaborator Author

Though does 4326 need an epoch? If so we should add what people should put for the epoch

I don't think we can "recommend" a value for the epoch, since that depends on your data.
We might want to add to the recommendation about EPSG:4326, that if you use EPSG:4326, it it also recommended to specify the epoch (although I don't know how important this is in this case, since EPSG:4326 has a low accuracy anyway).

(in general we might want to reconsider the recommendation of EPSG:4326 as I mentioned in #35 (the second bullet point), but let's leave that discussion for in the issue)

@rouault
Copy link
Contributor

rouault commented Mar 25, 2022

Though does 4326 need an epoch?

that's a question that could bring geodesists to disagree for hours.
Strictly speaking EPSG:4326 relies on the EPSG:6326 datum ensemble (https://epsg.org/datum_6326/World-Geodetic-System-1984-ensemble.html), that has an intrinsic inaccuracy of 2 meters, due to the oldest realizations like Transit being quite different from the latest ones, that disagree between them only at the centimer level. So for such a vaguely qualified object, a coordinate epoch doesn't make much sense.
However ... in many cases people may use the vague EPSG:4326 instead of using one of the latest realizations of WGS 84 or ITRFxxxx, but for a number of reasons (like people only knowing EPSG:4326 and freaking out when they see something different) they use EPSG:4326 instead of the proper code. In that case, qualifying the CRS with the epoch could be useful for later processing, where people would say "oh, they actually meant ITRF2014@2022.3".
There are even cases for a CRS/datum that is generally considered static (and for which a coordinate epoch normally doesn't make sense, ), like NAD83(2011), where adding a coordinate epoch might be useful, since there are high precision deformation models that can be used.

@cholmes
Copy link
Member

cholmes commented Mar 25, 2022

Gotcha, those explanations make sense. And yeah, I was thinking something like 'if you use 4326 then do X for epoch', but if it doesn't really matter then that seems fine to not.

(in general we might want to reconsider the recommendation of EPSG:4326 as I mentioned in #35 (the second bullet point), but let's leave that discussion for in the issue)

Let's actually break that out into its own issue. I've been having doubts about it as well.

@cholmes cholmes merged commit b949c9a into opengeospatial:main Apr 11, 2022
@cholmes cholmes added this to the 0.2 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants