More consistent spelling and punctuation for JSON types #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
approved these changes
Nov 22, 2022
I don't have a strong preference, but I think quotes around strings can help to clarify when you're referring to a literal string value instead of an object key, for example |
kylebarron
approved these changes
Nov 22, 2022
Yeah. Or |
jorisvandenbossche
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes more consistent use of the JSON types "object" (instead of JSON object or Map) and "number" (instead of double). Where we discuss string literals in the JSON metadata, they are double quoted and formatted as code (e.g.
"like this").Fixes #128.