Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify geographic vs non-geographic bbox values #145

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

tschaub
Copy link
Collaborator

@tschaub tschaub commented Nov 18, 2022

This updates the language about bbox to align with GeoJSON for geographic coordinates and give min/max examples for non-geographic coordinates.

Fixes #112.

(One thing to note - the GeoJSON spec is a bit misleading in saying that the bbox has values for "all axes of the most southwesterly point followed by all axes of the more northeasterly point." What it means is that the value for $i_0$ is the most westerly, the value for $i_1$ is the most southerly, the value for $i_n$ is the most easterly, and the value for $i_{n+1}$ is the most northerly. The values for all other items are the minima followed by the maxima. The way the spec reads, it sounds like the third item of a bbox for geometries with a z would be the z value for the most southwesterly point. Instead it should be the minimum z value for all coordinates. I'll bring this up on the GeoJSON list and submit an errata report if others agree.)

@jorisvandenbossche
Copy link
Collaborator

(One thing to note - the GeoJSON spec is a bit misleading in saying that the bbox has values for "all axes of the most southwesterly point followed by all axes of the more northeasterly point." ...

Yes, agreed with your analysis. I assume that for the z dimension it is actually min/max, and not the z of the most southwesterly / northeasterly points. But that's indeed not clear from the GeoJSON description.

Copy link
Collaborator

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bbox crossing the antimeridian
2 participants