Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(frontend) replace easy grommet components #2503

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

AntoLC
Copy link
Contributor

@AntoLC AntoLC commented Nov 13, 2023

Proposal

  • ♻️(frontend) replace grommet Cards components
  • ♻️(frontend) replace grommet Footer components
  • ♻️(frontend) replace grommet Anchor components
  • ♻️(frontend) replace grommet Tip components
  • ♻️(frontend) replace grommet Nav components

@AntoLC AntoLC self-assigned this Nov 13, 2023
@AntoLC AntoLC force-pushed the refacto/anthony/replace-easy-grommet-components branch 4 times, most recently from dfd9b2a to 807fc9a Compare November 15, 2023 09:22
@AntoLC AntoLC marked this pull request as ready for review November 15, 2023 09:33
We replace the grommet Cards components by our own components.
In order to do the transition to the cunningham design system,
we replace the grommet Footer component with our
custom Box components.
In order to do the transition to the cunningham design system,
we replace the grommet Tip component with the cunningham
Popover component.
In order to do the transition to the cunningham design system,
we replace the grommet Nav component.
@AntoLC AntoLC force-pushed the refacto/anthony/replace-easy-grommet-components branch from 807fc9a to bbaff3a Compare November 17, 2023 15:01
@AntoLC AntoLC merged commit a096b12 into master Nov 17, 2023
33 of 34 checks passed
@AntoLC AntoLC deleted the refacto/anthony/replace-easy-grommet-components branch November 17, 2023 15:18
lunika added a commit that referenced this pull request Nov 29, 2023
Added

- Meta description and meta title on the website from the API (#2516)
- Retrieve BBB learning analytics and send them through API
- Classroom attendance analytics (#2499)
- Add a language picker for the invite link on the website (#2504)

Changed

- Replace grommet DropButton component (#2513)
- On live, can now share resource when one is already shared (#2512)
- Remove persistency on token from invite link (#2505)
- Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503)
- Refacto widgets SharedLiveMedia (#2504)
- Replace grommet Button (#2453)
- Replace grommet Box (#2484)
- Replace grommet TextArea (#2500)
- Update psycopg to version 3
- Update node to version 20
- Replace pylti with oauthlib for LTI request validation
- Replace faker with @faker-js/faker (frontend)

Fixed

- Blocking error when shared document is deleted (#2504)
- Improve render sharing picture in live (#2508)
lunika added a commit that referenced this pull request Nov 29, 2023
Added

- Meta description and meta title on the website from the API (#2516)
- Retrieve BBB learning analytics and send them through API
- Classroom attendance analytics (#2499)
- Add a language picker for the invite link on the website (#2504)

Changed

- Replace grommet DropButton component (#2513)
- On live, can now share resource when one is already shared (#2512)
- Remove persistency on token from invite link (#2505)
- Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503)
- Refacto widgets SharedLiveMedia (#2504)
- Replace grommet Button (#2453)
- Replace grommet Box (#2484)
- Replace grommet TextArea (#2500)
- Update psycopg to version 3
- Update node to version 20
- Replace pylti with oauthlib for LTI request validation
- Replace faker with @faker-js/faker (frontend)

Fixed

- Blocking error when shared document is deleted (#2504)
- Improve render sharing picture in live (#2508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants