Fix OptionValueNamer to handle weird scenario #12941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some production server, Spree::Variant.new return a variant with only unit_vallue set to 1.0. This fix the unexpected scenario.
sigmundpetersen
added
the
bug-s1
dacook
reviewed
Oct 23, 2024
There was a problem hiding this comment.
I'm not sure what all the contexts are that this is used.
Also not sure when it can be nil
I'm thinking it might cause other problems by also clearing the value. We know that we don't cover this scenario in any other specs so can't say if it will or not.
So I think this approach might be safer, what do you think?https://github.com/openfoodfoundation/openfoodnetwork/pull/12940/files?w=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
On some production server, Spree::Variant.new return a variant with only unit_vallue set to 1.0. This fix the unexpected scenario.
Affected servers so far :
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates