Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 12939 #12940

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Bug 12939 #12940

merged 2 commits into from
Oct 23, 2024

Conversation

dacook
Copy link
Member

@dacook dacook commented Oct 23, 2024 •
edited
Loading

What? Why?

What should we test?

There are two scenarios:
git diff db/schema.rb | grep unit_value

  1. DB has a default value for spree_variants.unit_value,
    + t.float "unit_value", default: 1.0, null: false
  2. or not.

Scenario 1 is already tested in prod! US, DE and HU. Check the above git diff and test on a staging server.

  • Visit /admin/products
  • create a new product
  • view /admin/products again

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@dacook dacook marked this pull request as ready for review October 23, 2024 11:39
@dacook dacook added the bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users. label Oct 23, 2024
rioug
rioug approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than my solution ! thanks 🙏

@dacook dacook requested a review from mkllnk October 23, 2024 23:21
mkllnk
mkllnk approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are heroes for working this out late at night!

@mkllnk mkllnk merged commit 762e6ec into openfoodfoundation:master Oct 23, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

@rioug rioug rioug approved these changes

Assignees

@dacook dacook

Labels
bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users.
Projects
OFN Delivery board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActionView::Template::Error in admin/products_v3#index
3 participants
@dacook @mkllnk @rioug