Report Orders and Distributors should display variant

[chahmedejaz]

What? Why?

• Closes Report Orders and Distributors should display variant #12878
• This PR adds the report variant name under the "Variant" column to the Order and Distributor report to mimic what's been displayed on the orders page for the variant.
• Moreover, after changing the item name to "Product", existing selected column name with item_name selected, won't be selected anymore. So to keep the selected column names the same in this case, a data migration has been added which changes the selected item_name to the product in all the existing selected columns that already had selected item_name

What should we test?

• As described or discussed in the issue
• Moreover, please make sure that if the item name column was selected before deployment, then after deployment product column name would have to be selected or vise versa

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

[dacook]

Great work, and good thinking to migrate the options data to make it seamless for users.

I have a concern about the migration, do you think it's worth adding a test? Or are you confident you've already manually checked all possibilities?

[chahmedejaz]

I have a concern about the migration, do you think it's worth adding a test? Or are you confident you've already manually checked all possibilities?

@dacook - I'd manually tested all the possible use cases for this migration, I thought it would run only once so wasn't sure if it was worth a spec that would add up to the pipeline each time the workflow runs.
However, yes, I may have missed something in my manual testing, so I've added the specs for the use cases I could think of. Please review and let me know what you think about it. Thanks. :)

[dacook]

Wonderful, thank you.

Yes it's hard to know exactly what to spec or not. It's still production code that will modify data on every server, so I thought it worth being certain about exactly what it will and won't do.

I agree we don't need the test running every time, and maybe it would be possible to configure a runner to only test migrations when they are added. But I don't know if there's an easy way to do that. For now, I think we just occasionally archive the migrations and specs.

[rioug]

Looks good 👍