Report Orders and Distributors should display variant

[nicolasVr]

Description

This report should display the product variant. Instead the "variant" column displays the unit. So this report can not be used by shops who use variants.

Expected Behavior

Report should display the product variant.

Actual Behaviour

Only Product, unit... are included in report.

Steps to Reproduce

Ask a report where some products have various variants.

Workaround

Unkown

Severity

s3 ?
Together with #12877 hubs have some difficulty using various delivery methods in a same order cycle.

[chahmedejaz]

Hi @RachL - I've fixed this such that the values for the current "Variant" column are moved to the new columns named "Variant Unit" and the "Variant" column is now displaying the variant display name. Please review the attached screenshot below:

I think with this fix, we should rename the "Item Name" to "Product Name" as it displays product name only. The "Variant" column displays the display name for the variant if it's set. If it's not set, then we would be displaying the Product name in its place (which is also the same behavior on the products page).
Another thought to this might be to show the variant display name in "Item Name" if it's present. If no variant display name is set then "Item Name" displays the product name.

Please share your thoughts on it. Thanks

[nicolasVr]

Thanks Ahmed. Your fix answers my request. I think it would be fine to rename "Item Name" to "Product Name".

[RachL]

Hi @chahmedejaz thanks for the fix ❤️ ! LGTM

Another thought to this might be to show the variant display name in "Item Name" if it's present. If no variant display name is set then "Item Name" displays the product name.

What is the display we choose on the order? I would keep the same behavior as this report is showing orders.

[chahmedejaz]

What is the display we choose on the order? I would keep the same behavior as this report is showing orders.

@RachL - On the order's page, if the variant has the display name set, it gets displayed along with the unit in the round braces. If the variant name is not set, only the unit is displayed without braces.

With variant name:

Without variant name:

Now this behavior suggests another solution to use this in the current variant column i.e. If the variant name is present, then display it along with the unit in braces. Otherwise, display the unit without braces.
And this solution might turn out to be this:

I think this looks better, what do you guys say?
CC: @nicolasVr

[chahmedejaz]

Just found out that Order Cycle Distributor Totals by Supplier report has the same behavior as above. So, I think let's continue with this solution. 🙌