Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFC Orders update for pilot 1 and 2 #12899

Merged
merged 11 commits into from
Oct 10, 2024

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    c609107 View commit details
    Browse the repository at this point in the history
  2. Sync stock of multiple linked catalogs

    And the logic becomes a bit simpler.
    mkllnk committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    664f324 View commit details
    Browse the repository at this point in the history
  3. Remove duplicate method

    The method `CheckoutCallbacks#valid_order_line_items?` was a duplicate
    of `OrderStockCheck#valid_order_line_items?`.
    
    Apparently, it had been extracted twice:
    
     * 1d074c2
     * 06eb98b
    
    But the first commit duplicated the method while the second moved the
    original declaration.
    mkllnk committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    adf0340 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Synchronise stock with DFC catalog during checkout

    This will delay the checkout request by a few seconds if there's stock
    to sync. But we minimise the chance of missing reduced stock from orders
    on another platform.
    
    We still have a gap between the checkout and placing a backorder. In
    that time we can't guarantee enough stock. But let's tackle that after
    the pilot.
    mkllnk committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    71ca292 View commit details
    Browse the repository at this point in the history
  2. Fix locally flaky spec around date filters

    This spec would fail on Australian systems early in the morning or in
    other timezones accordingly.
    mkllnk committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f0b6403 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. DRY DFC product import

    mkllnk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a838ef4 View commit details
    Browse the repository at this point in the history
  2. Style growing class

    mkllnk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e429cb7 View commit details
    Browse the repository at this point in the history
  3. Fix import of zero-weight products

    We don't allow variants to have zero weight or volume. But a DFC import
    in production showed that some catalogs list products with zero weight.
    Despite the products having a weight, it's simpler to treat these as
    items.
    mkllnk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bda5065 View commit details
    Browse the repository at this point in the history
  4. Update products when importing them multiple times

    Instead of creating a new variant every time.
    mkllnk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    260e7ba View commit details
    Browse the repository at this point in the history
  5. Split growing class

    mkllnk committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cde757e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    86c9114 View commit details
    Browse the repository at this point in the history