DFC Orders update for pilot 1 and 2 #12899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And the logic becomes a bit simpler.
This will delay the checkout request by a few seconds if there's stock to sync. But we minimise the chance of missing reduced stock from orders on another platform. We still have a gap between the checkout and placing a backorder. In that time we can't guarantee enough stock. But let's tackle that after the pilot.
This spec would fail on Australian systems early in the morning or in other timezones accordingly.
We don't allow variants to have zero weight or volume. But a DFC import in production showed that some catalogs list products with zero weight. Despite the products having a weight, it's simpler to treat these as items.
Instead of creating a new variant every time.
mkllnk
added
the
user facing changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
We trying to run two pilots this week. This pull request contains bug fixes and extended functionality for these pilots.
Unfortunately, we don't have time for review and testing beforehand. So this will be released and deployed to uk-prod for production testing.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates