[DFC Orders] Backorder stock controlled products

app/jobs/backorder_job.rb

@@ -13,17 +13,9 @@ class BackorderJob < ApplicationJob
   sidekiq_options retry: 0
 
   def self.check_stock(order)
-    variants_needing_stock = order.variants.select do |variant|
-      # TODO: scope variants to hub.
-      # We are only supporting producer stock at the moment.
-      variant.on_hand&.negative?
-    end
-
-    linked_variants = variants_needing_stock.select do |variant|
-      variant.semantic_links.present?
-    end
+    links = SemanticLink.where(variant_id: order.line_items.select(:variant_id))
 
-    perform_later(order, linked_variants) if linked_variants.present?
+    perform_later(order) if links.exists?
   rescue StandardError => e
     # Errors here shouldn't affect the checkout. So let's report them
     # separately:
@@ -32,20 +24,25 @@ def self.check_stock(order)
     end
   end
 
-  def perform(order, linked_variants)
+  def perform(order)
     OrderLocker.lock_order_and_variants(order) do
-      place_backorder(order, linked_variants)
+      place_backorder(order)
     end
   rescue StandardError
     # If the backordering fails, we need to tell the shop owner because they
     # need to organgise more stock.
-    BackorderMailer.backorder_failed(order, linked_variants).deliver_later
+    BackorderMailer.backorder_failed(order).deliver_later
 
     raise
   end
 
-  def place_backorder(order, linked_variants)
+  def place_backorder(order)
     user = order.distributor.owner
+    linked_variants = order.variants.select do |variant|
+      # TODO: scope variants to hub.
+      # We are only supporting producer stock at the moment.
+      variant.on_hand&.negative? && variant.semantic_links.present?
+    end
 
     # We are assuming that all variants are linked to the same wholesale
     # shop and its catalog:

app/mailers/backorder_mailer.rb

@@ -3,9 +3,9 @@
 class BackorderMailer < ApplicationMailer
   include I18nHelper
 
-  def backorder_failed(order, linked_variants)
+  def backorder_failed(order)
     @order = order
-    @linked_variants = linked_variants
+    @linked_variants = order.variants
 
     I18n.with_locale valid_locale(order.distributor.owner) do
       mail(to: order.distributor.owner.email)

spec/jobs/backorder_job_spec.rb

@@ -34,7 +34,7 @@
 
       expect {
         BackorderJob.check_stock(order)
-      }.to enqueue_job(BackorderJob).with(order, [variant])
+      }.to enqueue_job(BackorderJob).with(order)
     end
 
     it "reports errors" do
@@ -48,8 +48,9 @@
 
   describe "#peform" do
     it "notifies owner of errors" do
+      incorrect_order = create(:order)
       expect {
-        subject.perform(order, [])
+        subject.perform(incorrect_order)
       }.to enqueue_mail(BackorderMailer, :backorder_failed)
         .and raise_error(NoMethodError)
     end
@@ -70,7 +71,7 @@
       )
 
       expect {
-        subject.place_backorder(order, [variant])
+        subject.place_backorder(order)
       }.to enqueue_job(CompleteBackorderJob).at(completion_time)
 
       # We ordered a case of 12 cans: -3 + 12 = 9

spec/mailers/backorder_mailer_spec.rb

@@ -4,13 +4,12 @@
 
 RSpec.describe BackorderMailer do
   let(:order) { create(:completed_order_with_totals) }
-  let(:variants) { order.line_items.map(&:variant) }
 
   describe "#backorder_failed" do
     it "notifies the owner" do
       order.distributor.owner.email = "jane@example.net"
 
-      BackorderMailer.backorder_failed(order, variants).deliver_now
+      BackorderMailer.backorder_failed(order).deliver_now
 
       mail = ActionMailer::Base.deliveries.first
       expect(mail.to).to eq ["jane@example.net"]