[DFC Orders] Backorder stock controlled products #12888
Conversation
We want to trigger the backordering for any linked product now. So let's do that check early and then select the variants in the background. It means less data passed to the job and less space for race conditions.
We aggregate quantities over the whole order cycle to account for cancelations and order adjustments by admins.
mkllnk
added
the
user facing changes
| @order = order | ||
| @linked_variants = linked_variants | ||
| @linked_variants = order.variants |
There was a problem hiding this comment.
This now lists all variants associated with an order, whether they're linked or not. Hmm, regardless we probably only want to know about variants that had errors. I'll wait to see where the PR goes..
There was a problem hiding this comment.
Yes, we don't actually know what users want. We have no data on that. In the pilots, I think, all variants will be linked. Looking at errors could be good but also another source for errors. I think that we should wait until this actually happens and what people say about it.
| # We are only supporting producer stock at the moment. | ||
| variant = item.variant | ||
| variant.semantic_links.present? && | ||
| (variant.on_demand == false || variant.on_hand&.negative?) |
There was a problem hiding this comment.
I wonder if the model (or a module like VariantStock) should be deciding what is backorderable? Perhaps it can even be a scope.
app/jobs/backorder_job.rb
Outdated
| needed_quantity = -1 * variant.on_hand | ||
| # We look at linked variants which are either stock controlled or | ||
| # are on demand with negative stock. | ||
| def backorder_items(order) |
There was a problem hiding this comment.
The method sounds like it performs the action (make a backorder), but it just selects the items. Perhaps:
| def backorder_items(order) | |
| def backorderable_items(order) |
|
@mkllnk in case you missed it, deployment to staging failed. |
RaggedStaff
added
pr-staged-uk
What? Why?
We now want stock controlled items to trigger backorders as well.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates