-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New settings screen to activate each connected app type #12721
Merged
RachL
merged 8 commits into
openfoodfoundation:master
from
dacook:connected-apps-settings-12549
Aug 8, 2024
Merged
New settings screen to activate each connected app type #12721
RachL
merged 8 commits into
openfoodfoundation:master
from
dacook:connected-apps-settings-12549
Aug 8, 2024
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fcea437 - Browse repository at this point
Copy the full SHA fcea437View commit details -
Only show enabled connected app types
The preference will be set from the admin interface in a new commit It would be nice if we had an array/list type for preferences. Probably not too hard to implement, but this will do.
Configuration menu - View commit details
-
Copy full SHA for 4223b36 - Browse repository at this point
Copy the full SHA 4223b36View commit details -
It wasn't really necessary, but I'm going to need this list in a moment, so we might as well use it. Also it allows us to ensure the options are listed in a certain order. Also maybe it will help protect against corrupt preferences.
Configuration menu - View commit details
-
Copy full SHA for 254e11a - Browse repository at this point
Copy the full SHA 254e11aView commit details -
Add connected apps settings screen
I considered adding a request spec, but figured it still doesnt' test the form, so better to use a full system spec.
Configuration menu - View commit details
-
Copy full SHA for 5d732d8 - Browse repository at this point
Copy the full SHA 5d732d8View commit details -
Set connected apps as enabled if any
Could have easily done this manually, but this makes the transition smoother. BTW I tested each case manually, didn't seem worth writing a spec.
Configuration menu - View commit details
-
Copy full SHA for bd48a98 - Browse repository at this point
Copy the full SHA bd48a98View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffe3f12 - Browse repository at this point
Copy the full SHA ffe3f12View commit details
Commits on Aug 7, 2024
-
Submit blank value if nothing selected
If a checkbox is not selected, the browser does not submit it at all.
Configuration menu - View commit details
-
Copy full SHA for a95aa1b - Browse repository at this point
Copy the full SHA a95aa1bView commit details -
I'm not sure, but I assume that Config.set will raise an exception if it failed.
Configuration menu - View commit details
-
Copy full SHA for 40c7794 - Browse repository at this point
Copy the full SHA 40c7794View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.