Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New settings screen to activate each connected app type #12721

Merged

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    fcea437 View commit details
    Browse the repository at this point in the history
  2. Only show enabled connected app types

    The preference will be set from the admin interface in a new commit
    
    It would be nice if we had an array/list type for preferences. Probably not too hard to implement, but this will do.
    dacook authored and RachL committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4223b36 View commit details
    Browse the repository at this point in the history
  3. Use whitelist

    It wasn't really necessary, but I'm going to need this list in a moment, so we might as well use it.
    Also it allows us to ensure the options are listed in a certain order.
    
    Also maybe it will help protect against corrupt preferences.
    dacook authored and RachL committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    254e11a View commit details
    Browse the repository at this point in the history
  4. Add connected apps settings screen

    I considered adding a request spec, but figured it still doesnt' test the form, so better to use a full system spec.
    dacook authored and RachL committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5d732d8 View commit details
    Browse the repository at this point in the history
  5. Set connected apps as enabled if any

    Could have easily done this manually, but this makes the transition smoother.
    
    BTW I tested each case manually, didn't seem worth writing a spec.
    dacook authored and RachL committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bd48a98 View commit details
    Browse the repository at this point in the history
  6. Move class definition inside migration

    dacook authored and RachL committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ffe3f12 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Submit blank value if nothing selected

    If a checkbox is not selected, the browser does not submit it at all.
    dacook committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a95aa1b View commit details
    Browse the repository at this point in the history
  2. Show success message

    I'm not sure, but I assume that Config.set will raise an exception if it failed.
    dacook committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    40c7794 View commit details
    Browse the repository at this point in the history