New settings screen to activate each connected app type

[dacook]

Funded feature code is #12543 [DFC] Anonymized orders endpoint

What? Why?

• Closes Allow instance managers to activate/deactivate connected apps #12549

I forgot to make the new admin settings screen hidden behind the connected_apps feature toggle. But after this issue we will be able to remove the toggle anyway, so it's probably ok.

Screenshot

What should we test?

As per issue. In addition:

• ensure connected_apps feature toggle is enabled

Note: Both connected app types are disabled by default, so the tab in Enterprise settings will not show until they are enabled.
Except for instances where connected apps are already in use:

Once-off migration

If there are enterprises with connected apps on the server already: then a once-off migration will enable them in Connected Apps Settings (to avoid them becoming unexpectedly hidden).

For example, on au_staging, discover_regen is in use, but affiliate_sales_data is not.
So it is expected that discover_regen will become enabled, but affiliate_sales_data will not.

irb(main):003:0> ConnectedApp.discover_regen.first&.enterprise&.permalink
=> "50-mile-farmers-market-morwell"
irb(main):004:0> ConnectedApp.affiliate_sales_data.first&.enterprise&.permalink
=> nil

Release notes

I guess "feature toggled". Although the settings screen can be accessed without the feature toggle (see above), it won't have any effect, so I don't think it's worth advertising.

[mkllnk]

Great simple implementation. 👍

[mkllnk]

We usually define these as sub-classes of the migration. The table name still works and it's definitely another namespace to the original model.

Thankfully, good_migrations ensures that we don't load the actual model here.

[rioug]

Looks good 👍

[RachL]

it won't have any effect, so I don't think it's worth advertising.

I agree 👍

however @dacook I've tried 3 times on both FR and AU and I can't stage the pr :/

[rioug]

There were some good_migration error in bugsnag, ie: https://app.bugsnag.com/yaycode/openfoodnetwork-aus/errors/66b0ce0c5e9c074bc4c15904?event_id=66b0ce0c00f6a8c721040000&i=sk&m=nw
Looks like we need to fix the migration, per Maikel's comment

[dacook]

@RachL ready to test on au_staging! If you are unable to test straight away, please remove stagin label so that Konrad is able to use it.

[RachL]

I'm on it, I will try to do it in one go 👍

[RachL]

ensure connected_apps feature toggle is enabled

I disabled it before the PR was stage, and it did not re-enabled it. But I think this is normal. In any case we will be able to update it manually in production.

Enterprise settings will not show until they are enabled

This is ok ✅

Thank you so much for handling this case @dacook I realize I've forgotten about it when writing the issue:

I guess super admins should be able to do it, but it's a minor problem and can be dealt with in a different request (which I will open an issue for only if this becomes a problem).

However:

Disabling disco regen does not seem possible

I ended up with a white page and the app remains available in enterprise settings. @dacook Is it because it's enable by default on AU with the old config? In that case it won't be a problem in production and we can merge.

Adding feedback label, but if it's ok feel free to merge 👍

[dacook]

Thanks @RachL , actually you uncovered a bug, oops! I have fixed this now, and added a success message when saving:

But I have discovered something else that I might need to do for this PR, see comment on issue.

[dacook]

Two new commits for review.

[RachL]

Awesome, LGTM! Many thanks @dacook 🙏

Merging 💪