[BUU] fix error 500 on hungary instance #12700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with :hu locale, call to `number_to_rounded` wiht parameter precision: nil breaks, adding significant: false fixes the issue
rioug
added
the
feature toggled
dacook
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Great, thanks for that. I wonder if this would be apparent on the old products screen too.
In any case, this solves it. But there's a risk it might come up elsehwere when we use this helper, and don't test in hu.
So it would be good to get to the bottom of it.. I'll try on my env.
|
Thanks for adding the testing details. As the fix has already been tested in production, I think it's not necessary to test on staging; I would support merging this now. |
|
Sure happy to merge |
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This PR #12683 fixes the first occurrence of the bug but uncovered another one.
When running with
:hulocale, call tonumber_to_roundedwith parameterprecision: nilbreaks, addingsignificant: falsefixes the issue.What should we test?
You'll need to set the server local to
hu:apps/openfoodnetwork/current/.env.stagingand change set locale tohuRelease notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates