Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Handle corrupt data and troubleshooting #12683

Merged

Conversation

dacook
Copy link
Member

@dacook dacook commented Jul 18, 2024

What? Why?

A couple of similar errors have come up this week

  1. A small code change that might help avoid the error on hu_prod.
  2. On fr_prod, I found some corrupt data was causing an error. This is now handled gracefully. Well, more gracefully than before. It will appear as below with the first option in the list selected:

Screenshot 2024-07-18 at 12 01 35 pm

What should we test?

Staging

  • Updating units on any product

fr_prod

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Although it defaults to false, somehow it seems to be evaluated as true on hu_prod...??!?!!1! (openfoodfoundation#12682)
Maybe this will help.
@dacook dacook changed the title Force significant: false for NumberHelper [BUU] Handle corrupt data and troubleshooting Jul 18, 2024
@dacook dacook added prod-test technical changes only These pull requests do not contain user facing changes and are grouped in release notes user facing changes Thes pull requests affect the user experience and removed technical changes only These pull requests do not contain user facing changes and are grouped in release notes labels Jul 18, 2024
@dacook

This comment was marked as resolved.

@dacook dacook marked this pull request as ready for review July 18, 2024 02:21
@dacook dacook added the bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. label Jul 18, 2024
@dacook dacook requested a review from chahmedejaz July 18, 2024 02:24
Copy link
Collaborator

@chahmedejaz chahmedejaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me. I think it's worth trying it out, 🤞

@filipefurtad0 filipefurtad0 added the pr-staged-fr staging.coopcircuits.fr label Jul 18, 2024
@filipefurtad0 filipefurtad0 self-assigned this Jul 18, 2024
@filipefurtad0 filipefurtad0 added pr-staged-fr staging.coopcircuits.fr and removed pr-staged-fr staging.coopcircuits.fr labels Jul 18, 2024
@filipefurtad0
Copy link
Contributor

Hey @dacook,

This is a though one to test, as I could not reproduce it either. So, I've created a list of products and changed their unit from:

  • Kg to g
  • g to kg
  • kg to L
  • Item to Kg
  • Kg to Item

Spotted no issues. So I'd say we're good to merge and, as you point out, await for feedback from production (FR and HU).

@filipefurtad0 filipefurtad0 merged commit f1e6f8b into openfoodfoundation:master Jul 18, 2024
61 of 62 checks passed
@filipefurtad0 filipefurtad0 added feature toggled These pull requests' changes are invisible by default and are grouped in release notes and removed pr-staged-fr staging.coopcircuits.fr labels Jul 18, 2024
@filipefurtad0
Copy link
Contributor

Releasing this one as feature-toggled, as it seems to relate only to BUU (as described on the issue).

@dacook
Copy link
Member Author

dacook commented Jul 25, 2024

fr_prod

I just checked on fr_prod, and it loads without error now ✅. The Unit Scale field is not marked as changed, so I guess the hub have since updated it anyway.

https://coopcircuits.fr/admin/products?producer_id=5658

hu_prod

The full fix for this is included in next week's release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. feature toggled These pull requests' changes are invisible by default and are grouped in release notes prod-test user facing changes Thes pull requests affect the user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants