-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Handle corrupt data and troubleshooting #12683
[BUU] Handle corrupt data and troubleshooting #12683
Conversation
Although it defaults to false, somehow it seems to be evaluated as true on hu_prod...??!?!!1! (openfoodfoundation#12682) Maybe this will help.
Ah ha, we found the problem.
08db0d6
to
918d440
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me. I think it's worth trying it out, 🤞
Hey @dacook, This is a though one to test, as I could not reproduce it either. So, I've created a list of products and changed their unit from:
Spotted no issues. So I'd say we're good to merge and, as you point out, await for feedback from production (FR and HU). |
f1e6f8b
into
openfoodfoundation:master
Releasing this one as feature-toggled, as it seems to relate only to BUU (as described on the issue). |
fr_prodI just checked on fr_prod, and it loads without error now ✅. The Unit Scale field is not marked as changed, so I guess the hub have since updated it anyway. https://coopcircuits.fr/admin/products?producer_id=5658 hu_prodThe full fix for this is included in next week's release. |
What? Why?
A couple of similar errors have come up this week
What should we test?
Staging
fr_prod
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.