Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUU] Prepares specs for enabling admin_style_v3 by default #12652

Merged
merged 7 commits into from
Jul 11, 2024
Merged

[BUU] Prepares specs for enabling admin_style_v3 by default #12652

merged 7 commits into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. Removes test case around shipped product 

    This is already covered on the v3 version of the spec, under ./spec/system/admin/products_v3/products_spec.rb:452
    @filipefurtad0 @dacook
    filipefurtad0 authored and dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6dd4bb3 View commit details
    Browse the repository at this point in the history

  2. Prepares smoke_tests_spec for admin_style_v3 

    Enables admin_style_v3 for smoke_tests_spec
    @filipefurtad0 @dacook
    filipefurtad0 authored and dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dfcd939 View commit details
    Browse the repository at this point in the history

  3. Simplifies specs, by replacing selector declaration with click_button

    @filipefurtad0 @dacook
    filipefurtad0 authored and dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7f6780b View commit details
    Browse the repository at this point in the history

  4. Sets up enterprise with payment and shipping methods 

    So that the warning does not need to be dismissed - which is not what we wish to test here
    @filipefurtad0 @dacook
    filipefurtad0 authored and dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7d1cb0c View commit details
    Browse the repository at this point in the history

  5. Removes the need for using overlapping_elements_helper 

    Improves the specs so we don't need to recurr to overlapping elements clicks, and removes the respective helper
    @filipefurtad0 @dacook
    filipefurtad0 authored and dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f7c47fe View commit details
    Browse the repository at this point in the history

  6. Prepares spec for admin_style_v3 - replaces TODO (1)

    @filipefurtad0 @dacook
    filipefurtad0 authored and dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5e933af View commit details
    Browse the repository at this point in the history

  7. Remove comments

    @dacook
    dacook committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c86f7f9 View commit details
    Browse the repository at this point in the history