[BUU] Prepares specs for enabling admin_style_v3 by default #12652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipefurtad0
added
the
user facing changes
filipefurtad0
force-pushed
the
activate_admin_style_v3_for_dev_test_and_new_servers
branch
3 times, most recently
from
0352cbd
to
5c03cfa
Compare
filipefurtad0
added
the
technical changes only
6 tasks
filipefurtad0
removed
the
user facing changes
dacook
reviewed
Jul 9, 2024
4 tasks
filipefurtad0
force-pushed
the
activate_admin_style_v3_for_dev_test_and_new_servers
branch
from
67ff67d
to
48c501f
Compare
|
I think to fully address issue #12627 we'd need to include a migration (something like this?) - draft here, to enable We'd also need to fix the TODO's on import_spec. I have a question on one of them, raised here. Edit: there is this bit which can still be improved; I'm referencing it here, so we don't lose track. |
4 tasks
filipefurtad0
changed the title
dacook
approved these changes
Jul 11, 2024
This is already covered on the v3 version of the spec, under ./spec/system/admin/products_v3/products_spec.rb:452
Enables admin_style_v3 for smoke_tests_spec
So that the warning does not need to be dismissed - which is not what we wish to test here
Improves the specs so we don't need to recurr to overlapping elements clicks, and removes the respective helper
dacook
force-pushed
the
activate_admin_style_v3_for_dev_test_and_new_servers
branch
from
4890e9e
to
c86f7f9
Compare
|
Rebased on master (git kindly resolved conflicts automatically for me 🤩 ) |
mkllnk
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already covered on the v3 version of the spec, under ./spec/system/admin/products_v3/products_spec.rb:452
What? Why?
Addresses the bullet points:
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates