-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Duplicate Language Display on New User Creation #12392
Fix Duplicate Language Display on New User Creation #12392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
The commit history seems unnecessary bulky though. It says 196 commits for one simple change. I'll go ahead and rebase it for you.
9460efe
to
9477725
Compare
I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks for your help 🙏
Hey @sergioosouzaa , Indeed, this was observable when logged in as an admin (before this PR): After staging your code, we can see the bug is fixed: Tested that the selected language is reflected on the user account, as before. Thanks for this! Merging. |
f269584
into
openfoodfoundation:master
What? Why?
There was a bug in user creation where the Base language was displayed twice. Initially, it was thought that this issue occurred due to having two versions of English in the .env file. However, it happened when a locale other than the base English (such as en_AU) was used. The helper would always append the source_locale (en), resulting in duplication.
This appending behavior (for the source_locale) has been removed, and now it no longer duplicates.
What should we test?
Set your .env with somethiing like this:
http://localhost:3000/admin/users/new
Release notes
Dependencies
Documentation updates