-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several missing translations since release v4.4.41 #12429
Comments
As this is shopfront facing, I'm bumping it as s2 👍 |
I've edited the title because initially I was convinced this was related to these Bugsnag errors, happening at least since 6 Apr on CA, 5 Apr on UK. These point to moment.js and the locales as well... However, staging the latest versions showed that this bug is occurring only since v4.4.41. |
These keys are untranslated for en_AU and en_US. Maybe #12392 did something with the language fallback solution? |
I remember now that the JS part of translations loads only the "available locales", not all locales to save on the JS bundle size. So without the source in there, it can't find the fallback translations. |
I confirmed on au-staging that it's fixed through the revert. |
Description
Introduced on v4.4.41.
We're seeing a missing JS translation in production:
remaining_in_stock: "Only %{quantity} left"
Edit:
we're also seeing that
spree.admin.orders.index.selected
is missing.
admin.order_cycles.status.open
Expected Behavior
Remaining stock in the shopfront should be translated.
Actual Behaviour
Remaining stock in the shopfront is not translated.
Steps to Reproduce
This seems to be reproducible for non-default locales, like
en_US.yml
, oren_AU.yml
; it does not seem to occur foren.yml
, orfr.yml
.As admin:
As a customer:
3. Visit the shopfron set-up in the previous steps
4. Notice the missing translation
As admin:
As admin:
Animated Gif/Screenshot
Workaround
Severity
bug-s3: a feature is broken but there is a workaround
Your Environment
Possible Fix
The text was updated successfully, but these errors were encountered: