-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow searching orders by customers' full name with comma and full name reversed #11891
Allow searching orders by customers' full name with comma and full name reversed #11891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is great.
For completeness it would be great to also search for reversed name with comma. Would you mind adding that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help !
Ye, let me add it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Hi @bmd08a1, I compared the results when searching for different combinations before and after your PR (the displayed name in the orders is 'Azra, Angel'):
ResultWe have a great improvement here! 💪 I couldn't find any other issues with your solution, so this one is ready for merging! 🚀 |
What? Why?
fullname_with_comma
for searching by full name with comma, e.g.John, Doe
fullname_with_comma
for searching by full name reversed, e.g.Doe John
What should we test?
/admin/orders/bulk_management
page.Mistery John
orJohn, Mistery
(as displayed to the user) with built-in sample dataRelease notes
Changelog Category (reviewers may add a label for the release notes):
Allow searching orders by customers' full name with comma and full name reversed