Fix navigation behavior on enterprise settings panel tabs #11799
Conversation
| @@ -37,6 +37,16 @@ export default class extends Controller { | |||
| window.addEventListener("tabs-and-panels:click", (event) => { | |||
| this.simulateClick(event.detail.tab, event.detail.panel); | |||
| }); | |||
|
|
|||
| window.addEventListener("popstate", (event) => { | |||
There was a problem hiding this comment.
Worth noting that this doesn't fire only on user navigation actions, but also any programmatic changes to history entries, such as history.pushState(). That's why I have to compare the panels to make sure we're responding to a new tab change. Other than that, popstate is a really useful event for solving this!
|
Hey @murjax , This is looking great. I've tried to sum it up in a video, as a quick demonstration: the above section displays a staging server in which the PR was not staged; below, we see a section from a server in which this PR was staged: https://www.loom.com/share/1e683d593f0b4087a9d04a6706861929?sid=ed2122ae-fc6c-4482-9ab1-adbb91fc61d8 This makes it possible to navigate back to sections which were changed, but not saved. Thanks! |
… spec where a modal does not need acceptance Tests forward navigation
…igation Moves test introduced by #11799 to avoid non-explicit modal acceptance
… spec where a modal does not need acceptance Tests forward navigation
What? Why?
Panel navigation through back and forward buttons isn't working on enterprise settings page. The tab selection changes, but the content does not change.
What should we test?
admin/enterprises/[ENTERPRISE-SLUG]/edit#/primary_details).Other: Make changes to form fields. Back/Forward navigation should show the "unsaved changes" alert.
Screencast.from.11-10-2023.01.13.42.PM.webm
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates