Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump tom-select from 2.2.3 to 2.3.1 #11759

Merged
merged 4 commits into from
Jan 25, 2024

Commits on Jan 23, 2024

  1. chore(deps): bump tom-select from 2.2.3 to 2.3.1

    Bumps [tom-select](https://github.com/orchidjs/tom-select) from 2.2.3 to 2.3.1.
    - [Release notes](https://github.com/orchidjs/tom-select/releases)
    - [Commits](orchidjs/tom-select@v2.2.3...v2.3.1)
    
    ---
    updated-dependencies:
    - dependency-name: tom-select
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and rioug committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cd9c505 View commit details
    Browse the repository at this point in the history
  2. Use send_keys to populate tom select input

    Setting the value directly doesn't trigger the search, presumably
    because it doesn't trigger any javascript event.
    rioug committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    270a310 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Add tomselect_select helper

    When using `tomselect_search_and_select` and searching isn't really
    required it leaves the dropdown option open. It can then cause problem
    when trying to interact with other element in the page. This happens
    because clicking on the chosen option happena before the searching
    finishes.
    We can now use `tomselect_select` when searching is not actually
    required.
    It should not be a problem when search is required, as capybara will
    wait for the option to appear on the page before clicking.
    rioug committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    9854574 View commit details
    Browse the repository at this point in the history
  2. Replace tomselect_search_and_select by tomselect_select

    In these scenarios, searching for the option is not actually required,
    we can directly click on the needed option. It prevent issue with
    the dropdown option staying open and breaking specs.
    rioug committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    67dc79b View commit details
    Browse the repository at this point in the history