chore(deps): bump tom-select from 2.2.3 to 2.3.1 #11759
Conversation
![dependabot[bot]](https://github.com/avatars/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
javascript
|
Some of the changes broke some integration test that are using |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/tom-select-2.3.1
branch
from
0b2fe63
to
d01d4b3
Compare
|
I'm stuck and not sure how to continue. My notes so far.. I had a look at the customer selector on admin orders page, and can't work out what's wrong yet. That one uses a specific Stimulus controller:
The problem is with loading remote data.
Upgrade clues:Comparing orchidjs/tom-select@v2.2.3...v2.3.0
Issues: https://github.com/orchidjs/tom-select/issuesjust one recent one open, but no obvious connection. |
|
Fixed the problem by using I also found a bug where customer search by first name doesn't work when creating a new order, it's fixed here #12015 and will need to be merged before we can merge this. |
rioug
force-pushed
the
dependabot/npm_and_yarn/tom-select-2.3.1
branch
from
67695de
to
4598c7c
Compare
Bumps [tom-select](https://github.com/orchidjs/tom-select) from 2.2.3 to 2.3.1. - [Release notes](https://github.com/orchidjs/tom-select/releases) - [Commits](orchidjs/tom-select@v2.2.3...v2.3.1) --- updated-dependencies: - dependency-name: tom-select dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Setting the value directly doesn't trigger the search, presumably because it doesn't trigger any javascript event.
rioug
force-pushed
the
dependabot/npm_and_yarn/tom-select-2.3.1
branch
from
4598c7c
to
270a310
Compare
When using `tomselect_search_and_select` and searching isn't really required it leaves the dropdown option open. It can then cause problem when trying to interact with other element in the page. This happens because clicking on the chosen option happena before the searching finishes. We can now use `tomselect_select` when searching is not actually required. It should not be a problem when search is required, as capybara will wait for the option to appear on the page before clicking.
In these scenarios, searching for the option is not actually required, we can directly click on the needed option. It prevent issue with the dropdown option staying open and breaking specs.
There was a problem hiding this comment.
Great!
I wonder in which case the browser would use set. Maybe when prefilling an input with historical data? That's probably not needed with a search input field but one could consider that a bug in tomselect. I don't think we care though. Or would accessibility aids like speech-to-text use set?
| def tomselect_select(value, options) | ||
| tomselect_wrapper = page.find("[name='#{options[:from]}']").sibling(".ts-wrapper") |
There was a problem hiding this comment.
It may be worth being a bit more explicit with the options:
| def tomselect_select(value, options) | |
| tomselect_wrapper = page.find("[name='#{options[:from]}']").sibling(".ts-wrapper") | |
| def tomselect_select(value, from:) | |
| tomselect_wrapper = page.find("[name='#{from}']").sibling(".ts-wrapper") |
|
Regarding the issue, am I right in saying it's a race condition, due to the input being filled in too early? In that case it sounds like a bug indeed. |
|
I just remembered that Gaetan won't be online this week, so I think better just to proceed as-is. Thanks to the testing, I think we can assume there's no regressions and merge without manual testing. |
It's a race condition, but due to clicking on an option before the search actually finished. There is nothing really telling us the search is still happening, but a user is never as quick as Capybara so it's not really an issue. I guess it could be considered a bug. |
Bumps tom-select from 2.2.3 to 2.3.1.
Release notes
Sourced from tom-select's releases.
Commits
69180fav2.3.1 Release2eecbfergba() instead of rgb(). Fixes #647b02c3ce"include relevant error messages"6473bddMerge branch 'master' of github.com:orchidjs/tom-selectdc7a1a6HTMLSelectElement doesn't have readOnly attribute. Fixes #650df86451Merge pull request #649 from ravage84/patch-1190a21bUpdate copyright year6d11820v2.3.0 Releasedceef1cremove jquery7bd39earemove deprecated hideInput() and showInput()You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)