[DFC API] add image to product #11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rioug
added
the
technical changes only
mkllnk
approved these changes
Nov 8, 2023
| @@ -14,6 +14,7 @@ def self.supplied_product(variant) | |||
| productType: product_type, | |||
| quantity: QuantitativeValueBuilder.quantity(variant), | |||
| spree_product_id: variant.product.id, | |||
| image_url: variant.product&.image&.url(:product) | |||
There was a problem hiding this comment.
On production, this will directly link to AWS S3. And in order to do that for variants, it will process the image first. That shouldn't be a problem because all images should be processed already. Just flagging it here in case there's some performance issue later.
swagger/dfc.yaml
Outdated
| @@ -343,11 +343,12 @@ paths: | |||
| dfc-b:usageOrStorageCondition: '' | |||
| dfc-b:totalTheoreticalStock: 0.0 | |||
| ofn:spree_product_id: 90000 | |||
| ofn:image: http://test.host/rails/active_storage/representations/redirect/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBZzBCIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--cec5b9e04720cada9134f6757e3dd8156aeccbf0/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaDdCem9MWm05eWJXRjBTU0lJY0c1bkJqb0dSVlE2RkhKbGMybDZaVjkwYjE5c2FXMXBkRnNIYVFId2FRSHciLCJleHAiOm51bGwsInB1ciI6InZhcmlhdGlvbiJ9fQ==--a8632e6a563a139dfae774530b275266f6aef5f5/logo-white.png | |||
There was a problem hiding this comment.
This value may change every time we generate the documentation. In other specs, I replaced variable values with a fixed value so that we don't see random changes.
Comment on lines
-350
to
+351
| dfc-b:stockLimitation: 0 | ||
| dfc-b:stockLimitation: 5 |
There was a problem hiding this comment.
I guess that's due to the different factory used?
dacook
approved these changes
Nov 8, 2023
Temporary solution as we wait for the DFC connector to be updated to support "dfc_b:image" for SuppliedProduct
dacook
force-pushed
the
11712_DFC_add_image_to_product
branch
from
94aae11
to
f76bdf0
Compare
mkllnk
approved these changes
Nov 8, 2023
mkllnk
added
the
api changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This is a funded feature :
11242 Discovery Endpoints- including testing, code review etc11242 Task within Macdoch Regen DiscoveryWhat? Why?
As explained on the issue, we don't think DFC can make image available on supplied product in a timely manner. So we work around that by adding a ofn specific identifier "ofn:image". It will eventually be replace by "dfc_b:image" in the DFC connector.
This is read only, we don't support adding a product with an image
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates