Fix rubocop warning

openfoodfoundation · Nov 3, 2023 · 94aae11 · 94aae11
1 parent b227138
commit 94aae11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/engines/dfc_provider/lib/dfc_provider/supplied_product.rb b/engines/dfc_provider/lib/dfc_provider/supplied_product.rb
@@ -2,8 +2,7 @@
 
 module DfcProvider
   class SuppliedProduct < DataFoodConsortium::Connector::SuppliedProduct
-    attr_accessor :spree_product_id
-    attr_accessor :image
+    attr_accessor :spree_product_id, :image
 
     def initialize(semantic_id, spree_product_id: nil, image_url: nil, **properties)
       super(semantic_id, **properties)
@@ -16,7 +15,7 @@ def initialize(semantic_id, spree_product_id: nil, image_url: nil, **properties)
       end
       # Temporary solution, will be replaced by "dfc_b:image" in future version of the DFC connector
       registerSemanticProperty("ofn:image") do
-        self.image
+        image
       end
     end
   end

diff --git a/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb b/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb
@@ -49,7 +49,7 @@
     end
 
     it "assigns an image_url type" do
-      image = Spree::Image.create!(
+      Spree::Image.create!(
         attachment: white_logo_file,
         viewable_id: variant.product.id,
         viewable_type: 'Spree::Product'