Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set background color of SlidingUpPanel by Theme and remove custom color from icons. #618

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Set background color of SlidingUpPanel by Theme and remove custom color from icons. #618

merged 1 commit into from
Oct 13, 2021

Conversation

Nols1000
Copy link
Contributor

This fixes #594.

@M123-dev
Copy link
Member

Thanks a lot @Nols1000 , can you maybe provide some screenshots of how the SlidingUpPanel looks now

@Nols1000
Copy link
Contributor Author

Hi,
no problem.

Search Panel Expanded Search Panel Search Input Field With Value

M123-dev
M123-dev approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Pull Request @Nols1000, the panel in Darkmode looks great. I am going to merge it now.

@M123-dev M123-dev merged commit 60b03bf into openfoodfacts:develop Oct 13, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The text of the scan card is not legible in dark mode
2 participants
@Nols1000 @M123-dev