-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5204 - preliminary step for multi-product price addition #5367
feat: 5204 - preliminary step for multi-product price addition #5367
Conversation
New files: * `price_amount_model.dart`: Model for the price of a single product. * `price_meta_product.dart`: Meta version of a product, coming from OFF or from Prices. * `price_product_search_page.dart`: Product Search Page, for Prices. * `price_product_list_tile.dart`: Displays a meta product with an action button, as a ListTile. Impacted files: * `app_en.arb`: added 2 labels for the new "price product search" page * `app_fr.arb`: added 2 labels for the new "price product search" page * `edit_product_page.dart`: minor refactoring * `get_prices_model.dart`: minor refactoring * `price_amount_card.dart`: minor refactoring * `price_amount_field.dart`: minor refactoring * `price_count_widget.dart`: minor refactoring * `price_model.dart`: moved product amount code to new class `PriceAmountModel` * `price_product_widget.dart`: unrelated UI refactoring * `prices_card.dart`: minor refactoring * `product_price_add_page.dart`: minor refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point in making the single price also editable? Can't we hide the pencil in those cases ? Making it possible to switch the barcode mid-course seems like a recipe for user mistakes.
The thing is that PR is a preliminary step: if I remove everything with a strong immediate added-value I can close the PR right away. I can indeed hide the edit button in this PR. Anyway the UI/UX will evolve. |
@teolemon I've just removed the "edit" button: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @monsieurtanuki 👍
Thank you @teolemon for your review! Next step: multi-products! Probably by the end of the week. |
What
This is the first step towards multi-product price addition:
Screenshots
Part of
Files
New files:
price_amount_model.dart
: Model for the price of a single product.price_meta_product.dart
: Meta version of a product, coming from OFF or from Prices.price_product_search_page.dart
: Product Search Page, for Prices.price_product_list_tile.dart
: Displays a meta product with an action button, as a ListTile.Impacted files:
app_en.arb
: added 2 labels for the new "price product search" pageapp_fr.arb
: added 2 labels for the new "price product search" pageedit_product_page.dart
: minor refactoringget_prices_model.dart
: minor refactoringprice_amount_card.dart
: minor refactoringprice_amount_field.dart
: minor refactoringprice_count_widget.dart
: minor refactoringprice_model.dart
: moved product amount code to new classPriceAmountModel
price_product_widget.dart
: unrelated UI refactoringprices_card.dart
: minor refactoringproduct_price_add_page.dart
: minor refactoring