-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to zoom out after rotating photo in the cropper #1538
Comments
Don't think this is possible with our current implementation |
Again, if you need a simple implementation with just the full image, a 90-180-270 rotation and a crop tool, I can dig up what I coded in another project. |
@alexgarel showed me the issue again yesterday. I grumbled, saying we should probably go back to the older cropper, which was a 90-180-270 rotation tool, until we can figure out how to make that work properly. |
@teolemon The older cropper you're referring to was in the V1, or already in Smoothie? There are currently 4 image croppers in pub.dev beyond 90%:
And of course we can code it from scratch, like I did in another project. At least we should test the first 3 of them. Is there a project for experiments or should we create one? Maybe I can do that with my aborted fast food project? The requirements I see are:
|
After discussing with @AshAman999 and @teolemon at the community point today, here are the minimum requirements for replacing the current cropper:
That way, we can ask the server to do the resizing stuff for us. |
Looks like it's going to be crop_image then. |
ping |
Looks good to me, it's no gorgeous UI (as before), it has no extraordinary features (like before), it stays the same with simpler UX so I like it |
Still working on it, but close to the end. |
For the record I've just remarked that the crop tool is significantly different in Android and iOS - which makes sense as we're talking about different native packages. That said, I'm about to PR a refactoring. That's a first step. I'm already working on the next steps. |
Impacted files: * `confirm_and_upload_picture.dart`: minor refactoring. * `image_crop_page.dart`: rather heavy refactoring needed to move forward.
Impacted files: * `confirm_and_upload_picture.dart`: minor refactoring. * `image_crop_page.dart`: rather heavy refactoring needed to move forward.
Impacted files: * `confirm_and_upload_picture.dart`: minor refactoring. * `image_crop_page.dart`: rather heavy refactoring needed to move forward.
Impacted files: * `image_crop_page.dart`: vertical buttons for gallery/camera dialog * `smooth_alert_dialog.dart`: fixed comment
Actually #2858 was just a first step. |
New files: * `crop_grid.dart`: heavily inspired from package `crop_image` - ideally we should put it back there. * `crop_helper.dart`: Crop Helper - which crop tool do we use, and the method to use it. * `new_crop_page.dart`: Page dedicated to image cropping. Pops the resulting file path if relevant. * `rotated_crop_controller.dart`: heavily inspired from package `crop_image` BUT with the rotation feature - ideally we should put it back there. * `rotated_crop_image.dart`: heavily inspired from package `crop_image` BUT with the rotation feature - ideally we should put it back there. * `rotation.dart`: 90 degree rotations - ideally we should put it back in package `crop_image` Impacted files: * `image_crop_page.dart`: now relying on new class `CropHelper` in order to get the appropriate crop tool (e.g. old or new) * `pubspec.lock`: wtf * `pubspec.yaml`: added package `image` for good performances regarding image encoding * `user_preferences_dev_mode.dart`: added a "Use new crop tool" switch (default is `false`)
New files: * `crop_grid.dart`: heavily inspired from package `crop_image` - ideally we should put it back there. * `crop_helper.dart`: Crop Helper - which crop tool do we use, and the method to use it. * `new_crop_page.dart`: Page dedicated to image cropping. Pops the resulting file path if relevant. * `rotated_crop_controller.dart`: heavily inspired from package `crop_image` BUT with the rotation feature - ideally we should put it back there. * `rotated_crop_image.dart`: heavily inspired from package `crop_image` BUT with the rotation feature - ideally we should put it back there. * `rotation.dart`: 90 degree rotations - ideally we should put it back in package `crop_image` Impacted files: * `image_crop_page.dart`: now relying on new class `CropHelper` in order to get the appropriate crop tool (e.g. old or new) * `pubspec.lock`: wtf * `pubspec.yaml`: added package `image` for good performances regarding image encoding * `user_preferences_dev_mode.dart`: added a "Use new crop tool" switch (default is `false`)
Yes I have been using it as my main for this time, actually remembered about it yesterday again but haven't had the time to create a issue yet. I think we can switch, but I haven't tested on iOS |
I was using this for the past week, works fine for iOS, Can't rotate to other angles other than 90 degrees, anyways it's light and does the job for me ✅ |
What
Steps to reproduce the behavior
Expected behavior
Just a rotation without zoom ?
Part of
Screenshot/Mockup/Before-After
screen-20220411-113914.mp4
The text was updated successfully, but these errors were encountered: