feat: 831 - Open Prices API - "get prices" #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `api_prices_test.dart`: Integration tests about the Open Prices API. * `currency.dart`: Currency of the price. * `get_prices_result.dart`: List of price objects returned by the "get prices" method. * `get_prices_result.g.dart`: generated * `get_prices_results.dart`: Either successful "get prices" result, or request validation errors. * `location_osm_type.dart`: Type of the OpenStreetMap location object. * `open_prices_api_client.dart`: Client calls of the Open Prices API. * `price.dart`: Price object. * `price.g.dart`: generated * `validation_error.dart`: Single API request validation error. * `validation_error.g.dart`: generated * `validation_errors.dart`: List of single API request validation errors. * `validation_errors.g.dart`: generated Impacted files: * `http_helper.dart`: minor refactoring * `labeler.yml`: added the "prices" files * `openfoodfacts.dart`: exported the new "prices" files
raphodn
reviewed
Dec 11, 2023
raphael0202
approved these changes
Dec 15, 2023
|
Thank you for the implementation :) |
|
Thank you @raphael0202 for your review! |
|
And thank you @raphodn for your comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of
Files
New files:
api_prices_test.dart: Integration tests about the Open Prices API.currency.dart: Currency of the price.get_prices_result.dart: List of price objects returned by the "get prices" method.get_prices_result.g.dart: generatedget_prices_results.dart: Either successful "get prices" result, or request validation errors.location_osm_type.dart: Type of the OpenStreetMap location object.open_prices_api_client.dart: Client calls of the Open Prices API.price.dart: Price object.price.g.dart: generatedvalidation_error.dart: Single API request validation error.validation_error.g.dart: generatedvalidation_errors.dart: List of single API request validation errors.validation_errors.g.dart: generatedImpacted files:
http_helper.dart: minor refactoringlabeler.yml: added the "prices" filesopenfoodfacts.dart: exported the new "prices" files