Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Nutri-Score helper #193

Closed
Tracked by #218
, #519
...
teolemon opened this issue Jul 20, 2021 · 5 comments
Closed
Tracked by #218
, #519
...

Add a Nutri-Score helper #193

teolemon opened this issue Jul 20, 2021 · 5 comments
Assignees
@monsieurtanuki
Labels
🚥 Nutri-Score 🛣️ Road to scores

Comments

@teolemon
Copy link
Member

Add a Nutri-Score helper to help apps get to the Nutri-Score instantly for their users

image

https://docs.google.com/document/d/1_Y3tdgB8w3VkL6tXgjzPVmkmFiXsBfy0UfS6Mg3MkLs/edit#heading=h.ftzz6kpf06gw
@monsieurtanuki monsieurtanuki mentioned this issue Aug 20, 2021
Open
@teolemon teolemon mentioned this issue Aug 20, 2021
Closed
3 tasks
@monsieurtanuki monsieurtanuki mentioned this issue Aug 21, 2021
Merged
@monsieurtanuki monsieurtanuki self-assigned this Aug 21, 2021
@teolemon teolemon mentioned this issue Aug 23, 2021
Open
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Aug 29, 2021
@monsieurtanuki
feature/openfoodfacts#193 - added ProductImprovements to 191's
d9806b2
@monsieurtanuki
Copy link
Contributor

Product improvements are now computed in product.getProductImprovements() (#217).
Beyond the enum values, I don't know how the translations are supposed to be integrated, and how.

@monsieurtanuki
Copy link
Contributor

@teolemon Should we provide messages and translations, or are we done now thanks to enum ProductImprovement and product.getProductImprovements()?
Same question for #191.

@teolemon
Copy link
Member Author

teolemon commented Oct 6, 2021

Translations can be done in smoothie @monsieurtanuki

@monsieurtanuki
Copy link
Contributor

Translations can be done in smoothie @monsieurtanuki

Then we can close this issue, can't we? And we should also ping both openfoodfacts/smooth-app#518 and openfoodfacts/smooth-app#519, shouldn't we?

@teolemon
Copy link
Member Author

teolemon commented Jul 3, 2022

yes, it's fixed by the actions API

@teolemon teolemon closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🚥 Nutri-Score 🛣️ Road to scores
Projects
Dart package - Support for new APIs and issues
Status: To do
🧃🛠️ Open Food Facts SDK tracking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @monsieurtanuki