Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: In some cases, the user password is not sent to the API #4575

Merged
merged 1 commit into from
Mar 21, 2022
Merged

fix: In some cases, the user password is not sent to the API #4575

merged 1 commit into from
Mar 21, 2022

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Mar 21, 2022

The user password is not always sent to the API.
This should resolve #3520

@g123k g123k requested a review from a team as a code owner March 21, 2022 17:05
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon merged commit db1eff3 into openfoodfacts:develop Mar 21, 2022
@teolemon teolemon added login Issues relating to allowing the user to log into their OFF accounts image upload Issues relating to image upload in products labels Mar 21, 2022
@VaiTon
Copy link
Member

VaiTon commented Apr 4, 2022

We should implement something to take care of that getString("user"... which is horrible and used in all the code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees
No one assigned
Labels
image upload Issues relating to image upload in products login Issues relating to allowing the user to log into their OFF accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image upload is not properly credited to the contributor
3 participants
@g123k @VaiTon @teolemon