Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #4546 Fixed sign up and password background buttons #4564

Merged

Conversation

krystelnguyen
Copy link
Contributor

Fixed #4546: #4546

@krystelnguyen krystelnguyen requested a review from a team as a code owner March 21, 2022 09:25
Copy link
Contributor

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon
Copy link
Member

small merge conflict @krystelnguyen @g123k

@g123k
Copy link
Contributor

g123k commented Mar 21, 2022

@krystelnguyen Could you resync your Git repo and push your commit again?

Added background to sing up and password buttons
@krystelnguyen krystelnguyen force-pushed the login_sing_up_password_background branch from 50e0664 to 0ba2c28 Compare March 24, 2022 08:21
@g123k g123k merged commit d1adb55 into openfoodfacts:develop Mar 24, 2022
@g123k
Copy link
Contributor

g123k commented Mar 24, 2022

Seems OK now, thanks for your PR @krystelnguyen!

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Login: Sign up & Password lost buttons have not visual cues of being pressed/touched
3 participants