Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to country template training upgrade #1208

Merged
merged 9 commits into from
May 3, 2024
Merged

Adapt to country template training upgrade #1208

merged 9 commits into from
May 3, 2024

Conversation

bonjourmauko
Copy link
Member

Technical changes

  • Adapt package to country template training upgrade
    • Remove use of obsolete pkg_resources
    • Refactor redundant metadata handling logic

@bonjourmauko bonjourmauko added level:intermediate Requires average OpenFisca experience kind:improvement Refactoring and code cleanup labels Mar 18, 2024
@coveralls
Copy link

coveralls commented Mar 18, 2024 •
edited
Loading

Coverage Status

coverage: 74.501% (+0.009%) from 74.492%
when pulling c837aef on training-upgrade
into 069c542 on master.

@bonjourmauko bonjourmauko mentioned this pull request Mar 19, 2024
Open
MattiSG
MattiSG approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bonjourmauko
Copy link
Member Author

Please let me know @verbman how would you like to proceed here. These changes require that a pyproject.toml is in place.

@verbman verbman mentioned this pull request Mar 20, 2024
Merged
@MattiSG
Copy link
Member

MattiSG commented May 2, 2024

Thanks a lot @bonjourmauko! Is there any reason left for this PR to be a draft? 🙂

@MattiSG
Copy link
Member

MattiSG commented May 3, 2024

I take responsibility to proceed with that PR since the country template has been upgraded and Core CI tests will fail otherwise.

@MattiSG MattiSG marked this pull request as ready for review May 3, 2024 15:03
@MattiSG MattiSG merged commit 51c3d43 into master May 3, 2024
22 checks passed
@MattiSG MattiSG deleted the training-upgrade branch May 3, 2024 15:04
@MattiSG MattiSG mentioned this pull request May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

@verbman verbman Awaiting requested review from verbman

Assignees
No one assigned
Labels
kind:improvement Refactoring and code cleanup level:intermediate Requires average OpenFisca experience
Projects
OpenFisca International
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bonjourmauko @coveralls @MattiSG