Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document value inference mechanisms #458

Closed
MattiSG opened this issue Feb 22, 2017 · 5 comments · Fixed by openfisca/openfisca-doc#35
Closed

Document value inference mechanisms #458

MattiSG opened this issue Feb 22, 2017 · 5 comments · Fixed by openfisca/openfisca-doc#35

Comments

@MattiSG
Copy link
Member

MattiSG commented Feb 22, 2017

There are currently a few places where inferences take place:

  • In parameters values, through the fuzzy attribute, which artificially extends the validity period of a value — Do not crash when asked for a parameter after end date #437.
  • In period management, through calculate_output, which can automatically sum or divide values over periods to match the requested period.
  • In period management, through set_input, which can automatically sum or divide input values over periods to match the computable period.
  • In some formulas, through base_function, which can yield values that the original requested formula could not compute on its own — Make explicit input variables temporal inferences #460.
  • In some formulas, through max_nb_cycles, which can block the computation toward the past and thus doesn't allow some values to be computed.

We need to agree on a common, systematic way of doing inferences, to avoid conflicting views such as in #437 or in branch extrapolate-intensive-variables-to-past.

The minimal output is a complete list of inferences and expected usage in the documentation, which could be based upon the above list.

The expected output is a set of helper functions, architectural changes and documentation that support a consistent way of inferring values in OpenFisca.

@MattiSG MattiSG self-assigned this Feb 22, 2017
@MattiSG
Copy link
Member Author

MattiSG commented Feb 22, 2017

I'm being told there's also something about “suggestions” — can @cbenz detail the current behaviour, in the same format as above?

Any other known inference behaviours should be listed here. Please refrain from debating about them for the moment.

@benjello
Copy link
Member

There is also the nb_cycles that also implictly do some time inference.

@MattiSG
Copy link
Member Author

MattiSG commented Mar 2, 2017

From #460 (comment):

max_nb_cycles is an implicit inference, since it may block the computation toward the past and thus doesn't allow some values to be computed.

@benjello is this the same as the nb_cycles you mentioned above?

@benjello
Copy link
Member

benjello commented Mar 2, 2017

Yes it is, sorry for not using the right term max_nb_cycles

@MattiSG
Copy link
Member Author

MattiSG commented Mar 6, 2017

Ok, it's been about 2 weeks that this reference issue was open. The time for collecting known inferences seems to be over. I updated the original post to include max_nb_cycles, and will open a PR in GitBook to document these inferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants