This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove unused dependencies in ethcore-sync
#9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused dependencies and move `rustc-hex` to tests because it is only used in tests
niklasad1
added
A0-pleasereview 🤓
debris
approved these changes
Sep 19, 2018
debris
added
A8-looksgood 🦄
cheme
approved these changes
Sep 19, 2018
5chdn
added
A7-looksgoodtestsfail 🤖
…ve-unused-dependencies
5chdn
added
the
A7-looksgoodcantmerge 🙄
|
Please, resolve conflicts :) |
debris
added
A8-looksgood 🦄
|
Late to the party here, but consider switching to |
dvdplm
added a commit
that referenced
this pull request
Sep 27, 2018
…mon-deps * origin/master: ethereum libfuzzer integration small change (#9547) cli: remove reference to --no-ui in --unlock flag help (#9616) remove master from releasable branches (#9655) ethcore/VerificationQueue don't spawn up extra `worker-threads` when explictly specified not to (#9620) RPC: parity_getBlockReceipts (#9527) Remove unused dependencies (#9589) ignore key_server_cluster randomly failing tests (#9639) ethcore: handle vm exception when estimating gas (#9615) fix bad-block reporting no reason (#9638) Use static call and apparent value transfer for block reward contract code (#9603) HF in POA Sokol (2018-09-19) (#9607) bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588) Add constantinople conf to EvmTestClient. (#9570)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused dependencies and move
rustc-hexastest-dependencybecause it isonly used for tests