This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Lower the max size of transaction packet to prevent going oversize. #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
|
It would indeed be nice to know what's causing the issue, so adding some traces in the propagator to check the estimated RLP size and the actual size when it overflows in |
debris
reviewed
Aug 14, 2018
| @@ -148,7 +148,8 @@ const MAX_PEER_LAG_PROPAGATION: BlockNumber = 20; | |||
| const MAX_NEW_HASHES: usize = 64; | |||
| const MAX_NEW_BLOCK_AGE: BlockNumber = 20; | |||
| // maximal packet size with transactions (cannot be greater than 16MB - protocol limitation). | |||
| const MAX_TRANSACTION_PACKET_SIZE: usize = 8 * 1024 * 1024; | |||
| // keep it under 8MB as well, cause it seems that it may result oversized after compression. | |||
| const MAX_TRANSACTION_PACKET_SIZE: usize = 5 * 1024 * 1024; | |||
There was a problem hiding this comment.
I don't understand. Before it was 8 * ..., which is 8MBs, not 16, right?
There was a problem hiding this comment.
I believe this is the maximum size of a single transaction RLP. So if the final size is correct (and not increased by compression), you'd be able to fit at most three 5MB transactions, and have 1MB remaining for the rest of the packet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #9255 (comment)
Still I'm quite unsure what could cause the packet to go oversize, it seems it might be a combination of:
estimate_sizein RLPMight be worth further debugging if someone is into it. @debris / @ngotchac ?