Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

removed client error #9253

Merged
merged 1 commit into from
Jul 31, 2018
Merged

removed client error #9253

merged 1 commit into from
Jul 31, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 30, 2018

there's only one private function using client error

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 30, 2018
@debris debris added the A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). label Jul 30, 2018
sorpaas
sorpaas approved these changes Jul 31, 2018
View reviewed changes
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like client::Error is just unused.

@5chdn 5chdn added this to the 2.1 milestone Jul 31, 2018
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 31, 2018
andresilva
andresilva approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andresilva andresilva merged commit 10f42a2 into master Jul 31, 2018
@debris debris deleted the remove_client_error branch July 31, 2018 11:24
ordian added a commit to ordian/parity that referenced this pull request Jul 31, 2018
@ordian
resolve merge conflicts
294c313 
* 'master' of https://github.com/paritytech/parity:
  removed client error (openethereum#9253)
  Implement EIP-1052 (EXTCODEHASH) and fix several issues in state account cache (openethereum#9234)
  Improve Tracer documentation (openethereum#9237)
  Update Dockerfile (openethereum#9242)
  block cleanup (openethereum#9117)
  Increase the number of sessions. (openethereum#9203)
  add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230)
  fix typo (openethereum#9232)
  Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221)
  Allow old blocks from peers with lower difficulty (openethereum#9226)
  Removes duplicate libudev-dev from Dockerfile (openethereum#9220)
  snap: remove ssl dependencies from snapcraft definition (openethereum#9222)
  remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195)
  Insert PROOF messages for some cases in blockchain (openethereum#9141)
  [Chain] Add more bootnodes (openethereum#9174)
  ethcore: update bn version (openethereum#9217)
  deserialize block only once during verification (openethereum#9161)
  Simple build instruction fix (openethereum#9215)
  Added --tx-queue-no-early-reject flag to disable early tx queue rejects (openethereum#9143)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
4 participants
@debris @andresilva @sorpaas @5chdn