Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

rpc: fix is_major_importing sync state condition #9112

Merged
merged 2 commits into from
Jul 23, 2018
Merged

rpc: fix is_major_importing sync state condition #9112

merged 2 commits into from
Jul 23, 2018

Conversation

andresilva
Copy link
Contributor

There's a similar definition here and this makes it consistent with that.

When we're waiting for peers we're technically not syncing but we're waiting to do it.

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jul 12, 2018
@5chdn 5chdn added this to the 2.1 milestone Jul 13, 2018
@5chdn
Copy link
Contributor

5chdn commented Jul 13, 2018

Does "fix" indicate we should backport it?

@5chdn 5chdn requested a review from tomusdrw July 13, 2018 10:23
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 13, 2018
@andresilva
Copy link
Contributor Author

Okay this has the unintended consequence of breaking the informant:

❯ ./target/release/parity --chain kovan --warp-barrier 7000000000
…
2018-07-13 11:45:39  Syncing       #0 0xa3c5…2cb9     0.00 blk/s    0.0 tx/s    0 Mgas/s      0+    0 Qed        #0    5/25 peers   9 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-07-13 11:45:44  Syncing       #0 0xa3c5…2cb9     0.00 blk/s    0.0 tx/s    0 Mgas/s      0+    0 Qed        #0    5/25 peers   9 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-07-13 11:45:49  Syncing       #0 0xa3c5…2cb9     0.00 blk/s    0.0 tx/s    0 Mgas/s      0+    0 Qed        #0    5/25 peers   9 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-07-13 11:45:54  Syncing       #0 0xa3c5…2cb9     0.00 blk/s    0.0 tx/s    0 Mgas/s      0+    0 Qed        #0    5/25 peers   9 KiB chain 7 KiB db 0 bytes queue 10 KiB sync  RPC:  0 conn,    0 req/s,    0 µs

It just starts printing because it thinks it's syncing even though it's still waiting for warp sync. Will need to fix this.

@andresilva andresilva added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jul 13, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018
@andresilva andresilva force-pushed the andre/fix-syncing-check-condition branch from 70350a9 to e5c3709 Compare July 20, 2018 11:19
@andresilva andresilva force-pushed the andre/fix-syncing-check-condition branch from e5c3709 to 39d1ac2 Compare July 20, 2018 11:39
@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jul 20, 2018
@andresilva
Copy link
Contributor Author

Added a special case for the informant so that it doesn't print when waiting for peers.

This was referenced Jul 22, 2018
Merged
Merged
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 23, 2018
@tomusdrw tomusdrw merged commit e6acbc5 into master Jul 23, 2018
@tomusdrw tomusdrw deleted the andre/fix-syncing-check-condition branch July 23, 2018 13:42
5chdn pushed a commit that referenced this pull request Jul 24, 2018
@andresilva @5chdn
rpc: fix is_major_importing sync state condition (#9112)
91871c8 
* rpc: fix is_major_importing sync state condition

* rpc: fix informant printout when waiting for peers
5chdn pushed a commit that referenced this pull request Jul 24, 2018
@andresilva @5chdn
rpc: fix is_major_importing sync state condition (#9112)
af16371 
* rpc: fix is_major_importing sync state condition

* rpc: fix informant printout when waiting for peers
5chdn added a commit that referenced this pull request Jul 25, 2018
@5chdn
Backports to 1.11.8-stable (#9144)
c754a02 
* parity-version: bump stable to 1.11.8

* ci: update version strings for snaps

* Be more graceful on Aura difficulty validation (#9164)

* Be more graceful on Aura difficulty validation

* test: rejects_step_backwards

* test: proposer_switching

* test: rejects_future_block

* test: reports_skipped

* test: verify_empty_seal_steps

* parity: fix UserDefaults json parser (#9189)

* parity: fix UserDefaults json parser

* parity: use serde_derive for UserDefaults

* parity: support deserialization of old UserDefault json format

* parity: make UserDefaults serde backwards compatible

* parity: tabify indentation in UserDefaults

* Fix bugfix hard fork logic (#9138)

* Fix bugfix hard fork logic

* Remove dustProtectionTransition from bugfix category

EIP-168 is not enabled by default

* Remove unnecessary 'static

* Disable per-sender limit for local transactions. (#9148)

* Disable per-sender limit for local transactions.

* Add a missing new line.

* rpc: fix is_major_importing sync state condition (#9112)

* rpc: fix is_major_importing sync state condition

* rpc: fix informant printout when waiting for peers

* fix verification in ethcore-sync collect_blocks (#9135)

* docker: update hub dockerfile (#9173)

* update Dockerfile for hub

update to Ubuntu Xenial 16.04
fix cmake version

* docker: fix tab indentation in hub dockerfile

* ethcore: update to parity-wasm 0.31

* rpc: fix broken merge
5chdn added a commit that referenced this pull request Jul 26, 2018
@5chdn
Backports to 2.0.1-beta (#9145)
e7dc0be 
* parity-version: bump beta to 2.0.1

* ci: update version strings for snaps

* Be more graceful on Aura difficulty validation (#9164)

* Be more graceful on Aura difficulty validation

* test: rejects_step_backwards

* test: proposer_switching

* test: rejects_future_block

* test: reports_skipped

* test: verify_empty_seal_steps

* Remove node-health (#9119)

* Remove node-health

* Remove ntp_servers

* Add --ntp-servers as legacy instead of removing it

* Add --ntp-servers to deprecated args

* Remove unused stuff

* Remove _legacy_ntp_servers

* parity: fix UserDefaults json parser (#9189)

* parity: fix UserDefaults json parser

* parity: use serde_derive for UserDefaults

* parity: support deserialization of old UserDefault json format

* parity: make UserDefaults serde backwards compatible

* parity: tabify indentation in UserDefaults

* Fix bugfix hard fork logic (#9138)

* Fix bugfix hard fork logic

* Remove dustProtectionTransition from bugfix category

EIP-168 is not enabled by default

* Remove unnecessary 'static

* Disable per-sender limit for local transactions. (#9148)

* Disable per-sender limit for local transactions.

* Add a missing new line.

* rpc: fix is_major_importing sync state condition (#9112)

* rpc: fix is_major_importing sync state condition

* rpc: fix informant printout when waiting for peers

* fix verification in ethcore-sync collect_blocks (#9135)

* docker: update hub dockerfile (#9173)

* update Dockerfile for hub

update to Ubuntu Xenial 16.04
fix cmake version

* docker: fix tab indentation in hub dockerfile

* rpc: fix broken merge

* rcp: remove node_health leftover from merge

* rpc: remove dapps leftover from merge
@andresilva andresilva mentioned this pull request Aug 29, 2018
Closed
@andresilva andresilva mentioned this pull request Sep 13, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
4 participants
@andresilva @5chdn @tomusdrw @sorpaas