Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Have space between feature cfg flag #8791

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Have space between feature cfg flag #8791

merged 1 commit into from
Jun 5, 2018

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Jun 5, 2018

@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jun 5, 2018
@sorpaas sorpaas added this to the 1.12 milestone Jun 5, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 5, 2018
niklasad1
niklasad1 approved these changes Jun 5, 2018
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

➜  parity git:(0174c631f) ✗ gg "feature="                             
.cargo/config:3:rustflags = ["-Ctarget-feature=+crt-static"]
docs/CHANGELOG-1.8.md:25:- Fix feature=final ([#7914)](https://github.com/paritytech/parity/pull/7914))

@niklasad1 niklasad1 merged commit 6ecc630 into master Jun 5, 2018
@niklasad1 niklasad1 deleted the sorpaas/typo-feature branch June 5, 2018 09:28
ordian added a commit to ordian/parity that referenced this pull request Jun 6, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
d998d0c 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Remove UI related settings from CLI (openethereum#8783)
  Remove windows tray and installer (openethereum#8778)
  docs: add changelogs for 1.10.6 and 1.11.3 (openethereum#8810)
  Fix ancient blocks queue deadlock (openethereum#8751)
  Disallow unsigned transactions in case EIP-86 is disabled (openethereum#8802)
  Fix evmbin compilation (openethereum#8795)
  Have space between feature cfg flag (openethereum#8791)
  rpc: fix address formatting in TransactionRequest Display (openethereum#8786)
dvdplm added a commit that referenced this pull request Jun 7, 2018
@dvdplm
Merge remote-tracking branch 'origin/master' into refactor/hashdb-gen…
4fd7990 
…eric

* origin/master:
  ethcore: fix ancient block error msg handling (#8832)
  CI: Fix docker tags (#8822)
  parity: fix indentation in sync logging (#8794)
  Removed obsolete IpcMode enum (#8819)
  Remove UI related settings from CLI (#8783)
  Remove windows tray and installer (#8778)
  docs: add changelogs for 1.10.6 and 1.11.3 (#8810)
  Fix ancient blocks queue deadlock (#8751)
  Disallow unsigned transactions in case EIP-86 is disabled (#8802)
  Fix evmbin compilation (#8795)
  Have space between feature cfg flag (#8791)
  rpc: fix address formatting in TransactionRequest Display (#8786)
  Conditionally compile ethcore public test helpers (#8743)
  Remove Result wrapper from AccountProvider in RPC impls (#8763)
  Update `license header` and `scripts` (#8666)
@ordian ordian mentioned this pull request Jun 26, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@5chdn 5chdn 5chdn approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
3 participants
@sorpaas @niklasad1 @5chdn