This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
network-devp2p: downgrade logging to debug, add target #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5chdn
added
A0-pleasereview 🤓
|
Hmm, is there ever a legitimate reason to ping self? We can downgrade logging level for now, but perhaps raise it back after further improvements to discovery (such as #8771). |
|
@jimpo no there isn't; this is a bug. we discussed internally to downgrade the log level AND also fix that bug in a different PR :) |
rphmeier
approved these changes
Jun 8, 2018
niklasad1
reviewed
Jun 8, 2018
util/network-devp2p/src/discovery.rs
Outdated
| @@ -358,19 +358,19 @@ impl Discovery { | |||
| Ok(Some(size)) if size == data.payload.len() => { | |||
| }, | |||
| Ok(Some(_)) => { | |||
| warn!("UDP sent incomplete datagramm"); | |||
| debug!(target: "discovery", "UDP sent incomplete datagramm"); | |||
niklasad1
approved these changes
Jun 8, 2018
dvdplm
added a commit
that referenced
this pull request
Jun 11, 2018
* master: Fix subcrate test compile (#8862) network-devp2p: downgrade logging to debug, add target (#8784) Clearing up a comment about the prefix for signing (#8828) Disable parallel verification and skip verifiying already imported txs. (#8834) devp2p: Move UDP socket handling from Discovery to Host. (#8790) Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803) Specify critical release flag per network (#8821) Fix `deadlock_detection` feature branch compilation (#8824) Use system allocator when profiling memory (#8831) added from and to to Receipt (#8756)
tavakyan
referenced
this pull request
in C4Coin/c4coin-parity
Jun 14, 2018
* network-devp2p: downgrade logging to debug, add target * network-devp2p: rename s/datagramm/datagram
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in #8589