Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Move triehash and trie-standardmap out of tree #8634

Closed
wants to merge 1 commit into from

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented May 15, 2018

Use triehash and trie-standardmap from crates.io

Part of #8620.

Use triehash and trie-standardmap from crates.io

Part of #8620.
@parity-cla-bot
Copy link

It looks like @dvdplm signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@dvdplm dvdplm self-assigned this May 15, 2018
@dvdplm dvdplm added the A0-pleasereview 🤓 Pull request needs code review. label May 15, 2018
@dvdplm dvdplm requested a review from rphmeier May 15, 2018 10:41
@5chdn 5chdn added the M5-dependencies 🖇 Dependencies. label May 15, 2018
@5chdn 5chdn added this to the 1.12 milestone May 15, 2018
@5chdn
Copy link
Contributor

5chdn commented May 15, 2018

Please always apply at least one M-label to each PR

@5chdn 5chdn requested a review from debris May 15, 2018 13:38
@debris debris added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 17, 2018
Copy link
Collaborator

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting onice due to #8620 (comment)

I believe it's not a good idea

@dvdplm dvdplm closed this May 18, 2018
@5chdn 5chdn deleted the chore/use-triehash-from-crates branch November 1, 2018 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M5-dependencies 🖇 Dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants