This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Untrusted RLP length overflow check #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A6-mustntgrumble 💦
rphmeier
reviewed
Aug 3, 2017
util/rlp/src/untrusted_rlp.rs
Outdated
| @@ -371,7 +371,8 @@ impl<'a> BasicDecoder<'a> { | |||
| } | |||
| let len = decode_usize(&bytes[1..begin_of_value])?; | |||
|
|
|||
| let last_index_of_value = begin_of_value + len; | |||
| let last_index_of_value = begin_of_value.overflowing_add(len) | |||
There was a problem hiding this comment.
does this compile? i thought overflowing_add returns (usize, bool). checked_add returns an Option, though.
There was a problem hiding this comment.
i'm not putting pleasereview for a reason here :)
i have some issues with cargo here
rphmeier
reviewed
Aug 3, 2017
util/rlp/src/untrusted_rlp.rs
Outdated
| @@ -385,7 +386,7 @@ impl<'a> BasicDecoder<'a> { | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
| use UntrustedRlp; | |||
| use {UntrustedRlp, DecodeError}; | |||
rphmeier
added
A4-gotissues 💥
NikVolf
added
A0-pleasereview 🤓
|
Fixes #6226 |
|
LGTM |
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.